feat(appBar): add tab in app bar #closes1280 #1811
Conversation
…form/geoview into 1280-footer-tabs-app-bar
kaminderpal
changed the title
…form/geoview into 1280-footer-tabs-app-bar
There was a problem hiding this comment.
Reviewed 8 of 13 files at r1, 6 of 9 files at r2, 5 of 10 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: 16 of 22 files reviewed, 7 unresolved discussions (waiting on @kaminderpal)
packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 55 at r2 (raw file):
const appBarComponents = useUIAppbarComponents(); const { hideClickMarker } = useMapStoreActions(); const activeFooterTabId = useUIActiveFooterBarTabId();
Why are we using footer id in app bar?
packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 154 at r2 (raw file):
// open appbar detail drawer when click on map. if (activeFooterTabId === 'details' && buttonPanelGroups?.details?.AppbarPanelButtonDetails?.panel) {
We should have the same logic for open appbar control... Technically, we should not have details in footer and in appbar at the same time
packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 189 at r2 (raw file):
useEffect(() => { // Log logger.logTraceUseEffect('APP-BAR - create group of appbar buttons from footer bar group', mapId);
Should be no mention of footer... appbar can work with no footer
packages/geoview-core/src/core/components/common/layout.tsx line 84 at r2 (raw file):
// // If we're on mobile // if (theme.breakpoints.down('md')) {
Do we need dead code?
packages/geoview-core/src/core/components/common/layout.tsx line 44 at r4 (raw file):
(layer: LayerListEntry): void => { onLayerListClicked?.(layer); console.log('change is firing..');
No console log, use logger with proper level
packages/geoview-core/src/core/components/details/details-panel.tsx line 282 at r2 (raw file):
if (anotherLayerEntry) { // Log // logger.logDebug('DETAILS-PANEL', 'select another', memoLayerSelectedItem, anotherLayerEntry.layerPath);
Can you uncomment logger
packages/geoview-core/src/core/components/details/details-panel.tsx line 287 at r2 (raw file):
} else { // Log // logger.logDebug('DETAILS-PANEL', 'select none', memoLayerSelectedItem);
Can you uncomment logger
There was a problem hiding this comment.
Reviewed 1 of 9 files at r2, 2 of 3 files at r3, 1 of 10 files at r4.
Reviewable status: 20 of 22 files reviewed, 7 unresolved discussions (waiting on @kaminderpal)
There was a problem hiding this comment.
Reviewable status: 18 of 23 files reviewed, 7 unresolved discussions (waiting on @jolevesq)
packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 55 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Why are we using footer id in app bar?
add TODO for this
packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 154 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
We should have the same logic for open appbar control... Technically, we should not have details in footer and in appbar at the same time
add TODO for this
packages/geoview-core/src/core/components/app-bar/app-bar.tsx line 189 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Should be no mention of footer... appbar can work with no footer
Done.
packages/geoview-core/src/core/components/common/layout.tsx line 84 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Do we need dead code?
add investigation for this
packages/geoview-core/src/core/components/common/layout.tsx line 44 at r4 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
No console log, use logger with proper level
Done.
packages/geoview-core/src/core/components/details/details-panel.tsx line 282 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Can you uncomment logger
Done.
packages/geoview-core/src/core/components/details/details-panel.tsx line 287 at r2 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Can you uncomment logger
Done.
There was a problem hiding this comment.
Reviewed 1 of 10 files at r4, 2 of 4 files at r6, all commit messages.
Reviewable status: 21 of 23 files reviewed, 4 unresolved discussions (waiting on @kaminderpal)
packages/geoview-core/src/core/components/common/enlarge-button-style.tsx line 30 at r6 (raw file):
width: '7rem !important', }, appBarEnlargeBtn: {
Put same name appBarEnlargeButton, like enlarege for for footer not Btn
There was a problem hiding this comment.
Reviewed 1 of 4 files at r6.
Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @kaminderpal)
There was a problem hiding this comment.
Reviewable status: 22 of 23 files reviewed, 1 unresolved discussion (waiting on @jolevesq)
packages/geoview-core/src/core/components/common/enlarge-button-style.tsx line 30 at r6 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Put same name appBarEnlargeButton, like enlarege for for footer not Btn
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r7, 1 of 2 files at r8.
Reviewable status: 22 of 23 files reviewed, all discussions resolved (waiting on @kaminderpal)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r8, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kaminderpal)
jolevesq
merged commit 65f743c
into
Canadian-Geospatial-Platform:develop
Description
Implement guide tab inside app bar
Fixes #1280
Issue created for mobile scrolling #1819
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Add the URL for your deploy!
https://kaminderpal.github.io/geoview/raw-feature-info.html
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is